fix phpstan

phpstan · Oct 12, 2022 · cbf413f · cbf413f
1 parent 89d446e
commit cbf413f
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/Type/ArrayType.php b/src/Type/ArrayType.php
@@ -275,19 +275,22 @@ public function setOffsetValueType(?Type $offsetType, Type $valueType, bool $uni
 			$offsetType = self::castToArrayKeyType($offsetType);
 		}
 
-		$isConstantOffset = $offsetType instanceof ConstantStringType || $offsetType instanceof ConstantIntegerType;
-
-		if ($isConstantOffset && $offsetType->isSuperTypeOf($this->keyType)->yes()) {
+		if (
+			($offsetType instanceof ConstantStringType || $offsetType instanceof ConstantIntegerType)
+			&& $offsetType->isSuperTypeOf($this->keyType)->yes()
+		) {
 			$builder = ConstantArrayTypeBuilder::createEmpty();
 			$builder->setOffsetValueType($offsetType, $valueType);
 			return $builder->getArray();
 		}
 
 		$array = new self(
 			TypeCombinator::union($this->keyType, $offsetType),
-			$unionValues || $isConstantOffset ? TypeCombinator::union($this->itemType, $valueType) : $valueType,
+			$unionValues || $offsetType instanceof ConstantStringType || $offsetType instanceof ConstantIntegerType
+				? TypeCombinator::union($this->itemType, $valueType)
+				: $valueType,
 		);
-		if ($isConstantOffset) {
+		if ($offsetType instanceof ConstantStringType || $offsetType instanceof ConstantIntegerType) {
 			return TypeCombinator::intersect($array, new HasOffsetValueType($offsetType, $valueType), new NonEmptyArrayType());
 		}