Do type checks on pass by reference parameters for non-builtin functi…

…ons and methods.

Initially, all pass by reference parameters were skipped for type checking. This change continues to skip
those checks for builtin PHP methods, but does check parameters for userland methods.

src/Rules/FunctionCallParametersCheck.php

@@ -278,7 +278,7 @@ public function check(
 			if ($this->checkArgumentTypes) {
 				$parameterType = TypeUtils::resolveLateResolvableTypes($parameter->getType());
 
-				if (!$parameter->passedByReference()->createsNewVariable()) {
+				if (!$parameter->passedByReference()->createsNewVariable() || !$isBuiltin) {
 					$accepts = $this->ruleLevelHelper->acceptsWithReason($parameterType, $argumentValueType, $scope->isDeclareStrictTypes());
 
 					if (!$accepts->result) {

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -297,6 +297,10 @@ public function testPassingNonVariableToParameterPassedByReference(): void
 				'Parameter #1 $array of function reset expects array|object, null given.',
 				39,
 			],
+			[
+				'Parameter #1 $s of function PassedByReference\bar expects string, int given.',
+				48,
+			],
 		]);
 	}
 
@@ -1623,4 +1627,17 @@ public function testDiscussion10454(): void
 		]);
 	}
 
+	public function testBug10626(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-10626.php'], [
+			[
+				'Parameter #1 $value of function PassedByReference\intByValue expects int, string given.',
+				16,
+			],
+			[
+				'Parameter #1 $value of function PassedByReference\intByReference expects int, string given.',
+				17,
+			],
+		]);
+	}
 }

tests/PHPStan/Rules/Functions/data/bug-10626.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace PassedByReference;
+
+function intByValue(int $value): void
+{
+
+}
+
+function intByReference(int &$value): void
+{
+
+}
+
+$notAnInt = 'not-an-int';
+intByValue($notAnInt);
+intByReference($notAnInt);