Fix number_format() with named arguments

phpstan · May 17, 2021 · d4fb41c · d4fb41c
1 parent e8ef187
commit d4fb41c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/resources/functionMap.php b/resources/functionMap.php
@@ -7786,8 +7786,7 @@
 'nsapi_response_headers' => ['array'],
 'nsapi_virtual' => ['bool', 'uri'=>'string'],
 'nthmac' => ['string', 'clent'=>'string', 'data'=>'string'],
-'number_format' => ['string', 'number'=>'float', 'num_decimal_places='=>'int'],
-'number_format\'1' => ['string', 'number'=>'float', 'num_decimal_places'=>'int', 'dec_separator'=>'string', 'thousands_separator'=>'string'],
+'number_format' => ['string', 'number'=>'float', 'num_decimal_places='=>'int', 'dec_separator='=>'string|null', 'thousands_separator='=>'string|null'],
 'NumberFormatter::__construct' => ['void', 'locale'=>'string', 'style'=>'int', 'pattern='=>'string'],
 'NumberFormatter::create' => ['NumberFormatter', 'locale'=>'string', 'style'=>'int', 'pattern='=>'string'],
 'NumberFormatter::format' => ['string', 'num'=>'', 'type='=>'int'],

diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -529,4 +529,13 @@ public function testBug3920(): void
 		$this->analyse([__DIR__ . '/data/bug-3920.php'], []);
 	}
 
+	public function testBugNumberFormatNamedArguments(): void
+	{
+		if (PHP_VERSION_ID < 80000 && !self::$useStaticReflectionProvider) {
+			$this->markTestSkipped('Test requires PHP 8.0');
+		}
+
+		$this->analyse([__DIR__ . '/data/number-format-named-arguments.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Functions/data/number-format-named-arguments.php b/tests/PHPStan/Rules/Functions/data/number-format-named-arguments.php
@@ -0,0 +1,3 @@
+<?php declare(strict_types = 1); // lint >= 8.0
+
+\number_format(200.00, decimals: 2, decimal_separator: ',', thousands_separator: '&nbsp;');