AnalyseApplication: Do not re-analyse stubs on every run

Instead, only analyse them on full runs. Since a change in any stub already invalidates the whole result cache, this means we only need to analyse them on full runs and then remember their errors for later.

src/Analyser/ResultCache/ResultCacheManager.php

@@ -179,6 +179,15 @@ public function restore(array $allAnalysedFiles, bool $debug, bool $onlyFiles, ?
 		$filteredErrors = [];
 		$filteredExportedNodes = [];
 		$newFileAppeared = false;
+
+		foreach ($this->stubFiles as $stubFile) {
+			if (!array_key_exists($stubFile, $errors)) {
+				continue;
+			}
+
+			$filteredErrors[$stubFile] = $errors[$stubFile];
+		}
+
 		foreach ($allAnalysedFiles as $analysedFile) {
 			if (array_key_exists($analysedFile, $errors)) {
 				$filteredErrors[$analysedFile] = $errors[$analysedFile];

src/Command/AnalyseApplication.php

@@ -43,12 +43,6 @@ public function analyse(
 		InputInterface $input,
 	): AnalysisResult
 	{
-		$projectStubFiles = [];
-		if ($projectConfigArray !== null) {
-			$projectStubFiles = $projectConfigArray['parameters']['stubFiles'] ?? [];
-		}
-		$stubErrors = $this->stubValidator->validate($projectStubFiles, $debug);
-
 		$resultCacheManager = $this->resultCacheManagerFactory->create([]);
 
 		$ignoredErrorHelperResult = $this->ignoredErrorHelper->initialize();
@@ -70,6 +64,22 @@ public function analyse(
 				$errorOutput,
 				$input,
 			);
+
+			$projectStubFiles = [];
+			if ($projectConfigArray !== null) {
+				$projectStubFiles = $projectConfigArray['parameters']['stubFiles'] ?? [];
+			}
+			if ($resultCache->isFullAnalysis() && count($projectStubFiles) !== 0) {
+				$stubErrors = $this->stubValidator->validate($projectStubFiles, $debug);
+				$intermediateAnalyserResult = new AnalyserResult(
+					array_merge($intermediateAnalyserResult->getErrors(), $stubErrors),
+					$intermediateAnalyserResult->getInternalErrors(),
+					$intermediateAnalyserResult->getDependencies(),
+					$intermediateAnalyserResult->getExportedNodes(),
+					$intermediateAnalyserResult->hasReachedInternalErrorsCountLimit(),
+				);
+			}
+
 			$resultCacheResult = $resultCacheManager->process($intermediateAnalyserResult, $resultCache, $errorOutput, $onlyFiles, true);
 			$analyserResult = $resultCacheResult->getAnalyserResult();
 			$internalErrors = $analyserResult->getInternalErrors();
@@ -81,8 +91,6 @@ public function analyse(
 			$errors = array_merge($errors, $internalErrors);
 		}
 
-		$errors = array_merge($stubErrors, $errors);
-
 		$fileSpecificErrors = [];
 		$notFileSpecificErrors = [];
 		foreach ($errors as $error) {