Report unresolvable type in @param-closure-this

phpstan · Mar 26, 2024 · f46c11c · f46c11c
1 parent 4f4e72d
commit f46c11c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/src/Rules/PhpDoc/IncompatiblePhpDocTypeRule.php b/src/Rules/PhpDoc/IncompatiblePhpDocTypeRule.php
@@ -73,6 +73,17 @@ public function processNode(Node $node, Scope $scope): array
 				$phpDocParamType = $phpDocParamTag->getType();
 				$tagName = $phpDocParamTag instanceof ParamTag ? '@param' : '@param-out';
 
+				if (
+					$phpDocParamTag instanceof ParamTag
+					&& $phpDocParamTag->getClosureThisType() !== null
+					&& $this->unresolvableTypeHelper->containsUnresolvableType($phpDocParamTag->getClosureThisType())
+				) {
+					$errors[] = RuleErrorBuilder::message(sprintf(
+						'PHPDoc tag @param-closure-this for parameter $%s contains unresolvable type.',
+						$parameterName,
+					))->identifier('parameterClosureThis.unresolvableType')->build();
+				}
+
 				if (!isset($nativeParameterTypes[$parameterName])) {
 					$errors[] = RuleErrorBuilder::message(sprintf(
 						'PHPDoc tag %s references unknown parameter: $%s',

diff --git a/tests/PHPStan/Rules/PhpDoc/IncompatiblePhpDocTypeRuleTest.php b/tests/PHPStan/Rules/PhpDoc/IncompatiblePhpDocTypeRuleTest.php
@@ -203,6 +203,10 @@ public function testRule(): void
 				'PHPDoc tag @param for parameter $a with type callable is incompatible with native type InvalidPhpDoc\NotCallable.',
 				349,
 			],
+			[
+				'PHPDoc tag @param-closure-this for parameter $cb contains unresolvable type.',
+				357,
+			],
 		]);
 	}
 

diff --git a/tests/PHPStan/Rules/PhpDoc/data/incompatible-types.php b/tests/PHPStan/Rules/PhpDoc/data/incompatible-types.php
@@ -350,3 +350,11 @@ function paramInvokedCallableWithNotCallable(NotCallable $a): void
 {
 
 }
+
+/**
+ * @param-closure-this int $cb
+ */
+function paramClosureThisWithNonObject(callable $cb): void
+{
+
+}