Skip to content

Commit

Permalink
Fix renamed trait method visibility
Browse files Browse the repository at this point in the history
  • Loading branch information
ondrejmirtes committed Jan 3, 2022
1 parent c0aad86 commit fc5be6a
Show file tree
Hide file tree
Showing 3 changed files with 52 additions and 4 deletions.
8 changes: 4 additions & 4 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -552,4 +552,10 @@ public function testCountableBug(): void
$this->analyse([__DIR__ . '/data/countable-bug.php'], []);
}

public function testBug6264(): void
{
$this->phpVersionId = PHP_VERSION_ID;
$this->analyse([__DIR__ . '/data/bug-6264.php'], []);
}

}
42 changes: 42 additions & 0 deletions tests/PHPStan/Rules/Methods/data/bug-6264.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
<?php declare(strict_types = 1);

namespace Bug6264;

interface Foo
{
public function doFoo(): void;
}

class Bar implements Foo
{
public function doFoo(): void
{
echo "Doing foo the generic way";
}
}

trait SpecificFoo
{
public function doFoo(): void
{
echo "Doing foo the specific way";
}
}

class Baz extends Bar
{
use SpecificFoo {
doFoo as private doFooImpl;
}

public function doFoo(): void
{
echo "Doing foo twice";
$this->doFooImpl();
}
}

class FooBar extends Bar
{
use SpecificFoo;
}

0 comments on commit fc5be6a

Please sign in to comment.