Fix PDOException::getCode return type #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
exceptionGetCode
branch
from
64e7ed5
to
62acc52
Compare
VincentLanglet
force-pushed
the
exceptionGetCode
branch
from
62acc52
to
0c68467
Compare
|
Since a similar issue/PR is made on psalm for this change vimeo/psalm#7673, I'd like you opinion on this @ondrejmirtes, in order to move forward the PR on psalm and still have the same behavior with both static analyser. If someone use both psalm and phpstan, with only one of the two static analyser changing the return type of |
ondrejmirtes
requested changes
Feb 23, 2022
| if ($pdoException->isSuperTypeOf($classType)->yes()) { | ||
| $types[] = new StringType(); | ||
| $types[] = new UnionType([new IntegerType(), new StringType()]); |
There was a problem hiding this comment.
I'd rather be if this was a benevolent union type.
There was a problem hiding this comment.
Sure, I made the change
VincentLanglet
force-pushed
the
exceptionGetCode
branch
from
a45c54e
to
a35ab1a
Compare
VincentLanglet
force-pushed
the
exceptionGetCode
branch
from
a35ab1a
to
6acfaff
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#6651