Fix/issue 5903 #1051
Merged
Fix/issue 5903 #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Mar 6, 2022
src/Analyser/NodeScopeResolver.php
Outdated
| @@ -823,6 +823,9 @@ private function processStmtNode( | |||
| if (!$isIterableAtLeastOnce->no()) { | |||
| $throwPoints = array_merge($throwPoints, $finalScopeResult->getThrowPoints()); | |||
| } | |||
| if (!$scope->getType($stmt->expr)->isArray()->yes()) { | |||
There was a problem hiding this comment.
What about this instead?
!(new ObjectType(\ArrayAccess))->isSuperTypeOf($scope->getType($stmt->expr)-)->no()There was a problem hiding this comment.
This will make it not report a false positive for example array|null.
There was a problem hiding this comment.
Thank you! I'll look into it.
ondrejmirtes
force-pushed
the
fix/issue-5903
branch
from
1345f32
to
83e4284
Compare
|
Sorry, I used a wrong type in the review and fixed it myself :) 83e4284 (ArrayAccess has nothing to do with iteration). Thank you. |
ondrejmirtes
approved these changes
Mar 6, 2022
Oh, you are right. Sorry that I couldn't notice it. I’m wondering why did the tests passed in local. |
|
Because these objects might implement ArrayAccess in a subclass :) (They're not final.) So the assumption an exception might be thrown is still correct. |
|
I see. Thank you for clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#5903