add regression test for ArrayAccess and move logic #1055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to investigate a little more to understand this code. |
ondrejmirtes
force-pushed
the
test/bug-1903-add-regression
branch
from
bc89e83
to
54d9f5a
Compare
|
I'll try it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was working with #1054
I noticed that 0f64ca7 logic may be moved out of
!(new ObjectType(ArrayAccess::class))->isSuperTypeOf($varType)->yes()block, because it is using$originalValueToWrite.This PR moved the logic and added some regression tests for
ArrayAccess.