Update various DB functions for more specific row counts #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Mar 25, 2022
staabm
reviewed
Mar 25, 2022
| @@ -11535,7 +11535,7 @@ | |||
| 'sqlsrv_prepare' => ['resource|false', 'conn'=>'resource', 'sql'=>'string', 'params='=>'array', 'options='=>'array'], | |||
| 'sqlsrv_query' => ['resource|false', 'conn'=>'resource', 'sql'=>'string', 'params='=>'array', 'options='=>'array'], | |||
| 'sqlsrv_rollback' => ['bool', 'conn'=>'resource'], | |||
| 'sqlsrv_rows_affected' => ['int|false', 'stmt'=>'resource'], | |||
| 'sqlsrv_rows_affected' => ['int<-1,max>|false', 'stmt'=>'resource'], | |||
There was a problem hiding this comment.
I would assume this function will also return a numeric-string when the number is big enough.
it should have the same technical limitations then other *row_affected functions (even if it is not documented in the php-src manual)
There was a problem hiding this comment.
Even PDO does not document this, only MySQLi, and I suspect it's because it's a deeply PHP-integrated driver, so I think I'd rather leave these as is as I do not know.
There was a problem hiding this comment.
Thanks for the hint. Lets see, maybe php/doc-en#1483 Is helpfull
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found all these while working on doctrine/dbal#5334