Add non regression tests #1155
Add non regression tests #1155
Conversation
| /** @var A[] */ | ||
| $y = doFoo(); | ||
|
|
||
| $x = array_fill_keys($y, null); | ||
|
|
||
| assertType('array<string, null>', $x); |
There was a problem hiding this comment.
there should not be any code at the top level of a test. please move it into a method (same in other test files)
There was a problem hiding this comment.
Sure, but can you explain me why ?
There was a problem hiding this comment.
IIRC code on the top level would be executed when running the test suite. but we just want phpstan to analyse it
VincentLanglet
force-pushed
the
regressionTetss
branch
2 times, most recently
from
fb73614
to
5128351
Compare
VincentLanglet
force-pushed
the
regressionTetss
branch
from
5128351
to
a553f1e
Compare
|
Regressions tests added @ondrejmirtes =) |
| // Incorrect! This is DOMNode|null not DOMElement|null | ||
| // It's also possible to contain a DOMText node, which is not an instance | ||
| // of DOMElement, but an instance of DOMNode! | ||
| if ($element->firstChild instanceof DOMText) { |
There was a problem hiding this comment.
This test would never fail. The error message is: Instanceof between DOMElement|null and DOMText will always evaluate to false.
This test needs to be in ImpossibleInstanceOfRuleTest. Please verify that locally by reverting the stubs update commit. Thanks.
There was a problem hiding this comment.
I updated the test
It fails without the stub update
|
Thank you very much! |
Closes phpstan/phpstan#5846
Closes phpstan/phpstan#6213
Closes phpstan/phpstan#2567 (in the issue 5846)
Closes phpstan/phpstan#2471