Add @no-named-arguments check to MethodSignatureRule
#1400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @jrmajor I've also seen |
|
@ondrejmirtes I've seen that in PHPUnit too, but last time I've checked Psalm didn't support that, so I've decided to get it working with methods first :) BTW, I would appreciate you pointing me in the right direction with that PR... |
|
I'll rebase and adjust this PR once I merge #1403. |
ondrejmirtes
force-pushed
the
no-named-args-inheritance
branch
from
826f763
to
713b2a8
Compare
|
Alright, did some modifications: 7bb0fc1 Can you please finish the PR so that the build is green? Thanks :) |
ondrejmirtes
force-pushed
the
no-named-args-inheritance
branch
from
713b2a8
to
7bb0fc1
Compare
jrmajor
force-pushed
the
no-named-args-inheritance
branch
2 times, most recently
from
93d837b
to
812eae3
Compare
jrmajor
force-pushed
the
no-named-args-inheritance
branch
2 times, most recently
from
7e58d45
to
5a19c72
Compare
Add a check preventing a child method from declaring `@no-named-arguments` when parent method does not Co-authored-by: Ondrej Mirtes <ondrej@mirtes.cz>
jrmajor
force-pushed
the
no-named-args-inheritance
branch
from
5a19c72
to
9552158
Compare
|
@ondrejmirtes I'm sorry, I don't know why these tests are failing (these aren't new ones, I've added them in the previous PR, in 598bda2). |
|
Hi, I'm cleaning up old and stale PRs. Please send a new PR if you're still interested, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check preventing a child method from declaring
@no-named-argumentswhen the parent method does not.