Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XmlReader::next|read() has side-effects #1551

Merged
merged 2 commits into from Jul 25, 2022
Merged

XmlReader::next|read() has side-effects #1551

merged 2 commits into from Jul 25, 2022
+56 −0

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jul 25, 2022 •
edited

@staabm staabm marked this pull request as ready for review July 25, 2022 19:07
ondrejmirtes
ondrejmirtes requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The error on line 39 here https://phpstan.org/r/0a7a5b40-8c5b-40af-bd7d-66cea71e8363 isn't tested
  2. Instead of rule-specific tests, NodeScopeResolverTest would be more fitting here.

@staabm
Copy link
Contributor Author

staabm commented Jul 25, 2022

thx, turned into a NodeScopeResolverTest

@ondrejmirtes ondrejmirtes merged commit 5aa9a3c into phpstan:1.8.x Jul 25, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm mentioned this pull request Jul 25, 2022
Merged
@staabm staabm deleted the xmlreader branch June 21, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@staabm @ondrejmirtes