Fix Array_ expr type resolving with unpacked array items #1586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7724
The problem was the missing
$optional
arg for the ConstantArrayTypeBuilder::setOffsetValueType for the first conditional handling string keys. Unpacked array item values are always optional in that context as long as the array is not iterable at least once.UPDATE: One more thing was looking weird to me which I fixed in the second commit. I removed the check of
$valueType->getIterableValueType()->isIterableAtLeastOnce()
which goes too far if I'm not mistaken. As the iterableValueType does not influence the outer array non-emptyness basically. See the affected test files for bug-5287