Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix supertype checks between static and final class #1703

Merged
merged 1 commit into from Sep 6, 2022
Merged

Fix supertype checks between static and final class #1703

merged 1 commit into from Sep 6, 2022

Conversation

rvanvelzen
Copy link
Contributor

@ondrejmirtes
Copy link
Member

Because of the static keyword, the code sample probably shouldn't be tested before 8.0. The failures on 7.2 and 7.3 is because this RFC is in effect since 7.4: https://wiki.php.net/rfc/covariant-returns-and-contravariant-parameters

@ondrejmirtes ondrejmirtes merged commit e9ccd47 into phpstan:1.8.x Sep 6, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@rvanvelzen rvanvelzen deleted the bug-7717 branch September 6, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rvanvelzen @ondrejmirtes