Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly optimize TypeCombinator::reduceArrays() even more #1814

Merged
merged 1 commit into from Oct 11, 2022

Conversation

rvanvelzen
Copy link
Contributor

Keep track of the actual overlapping keys and only try merging when the overlapping keys match completely

@rvanvelzen rvanvelzen changed the base branch from 1.9.x to 1.8.x October 11, 2022 09:44
@rvanvelzen rvanvelzen marked this pull request as ready for review October 11, 2022 10:02
@ondrejmirtes
Copy link
Member

Nice, thank you!

@ondrejmirtes ondrejmirtes merged commit b39686f into phpstan:1.8.x Oct 11, 2022
@rvanvelzen rvanvelzen deleted the reduce-arrays-optimize branch October 11, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants