Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rewinddir() return type #192

Merged
merged 1 commit into from May 4, 2020
Merged

Fix rewinddir() return type #192

merged 1 commit into from May 4, 2020

Conversation

steevanb
Copy link
Contributor

@steevanb steevanb commented May 4, 2020

@ondrejmirtes
Copy link
Member

Thank you!

@phil-davis
Copy link
Contributor

Note: these sort of changes are not "strictly backwards-compatible".
owncloud/core#37335 - CI broke because it was "expecting this error and ignoring it" but now the bug has been fixed and so the error does not happen and phpstan complains.

I don't know what you should do about these sort of fixes - actually the fix is "a good thing" (tm) - but suddenly people's CI breaks.

@ondrejmirtes
Copy link
Member

@phil-davis Yeah, my stance is that most people are glad that PHPStan finds new bugs in their code.

If you want to minimize chances your CI will break, you can:

  1. Set reportUnmatchedIgnoredErrors to false to prevent the error you're talking about.
  2. Require specific PHPStan version 0.12.22 instead of a looser constraint like ^0.12.22 if you really want your build to stay green.

PHPStan is honoring backwards compatibility in the sense that your configuration file will not break in minor versions (0.12.x - when x increases), and also that the extensions API remains the same in minor versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants