Fix resolving of __DIR__, __NAMESPACE__ in traits #2043
Conversation
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
trait-magic
branch
5 times, most recently
from
bd007ad
to
cc8c0ca
Compare
staabm
force-pushed
the
trait-magic
branch
4 times, most recently
from
eda5b21
to
fe1e5ab
Compare
staabm
force-pushed
the
trait-magic
branch
3 times, most recently
from
d724ad9
to
dac2fd9
Compare
staabm
force-pushed
the
trait-magic
branch
2 times, most recently
from
0a4f077
to
c3b1032
Compare
staabm
force-pushed
the
trait-magic
branch
2 times, most recently
from
fcbf700
to
8032644
Compare
| { | ||
| public function doFoo(): void | ||
| { | ||
| assertType('string', __CLASS__); |
There was a problem hiding this comment.
I am wondering that we don't get a class-string here
There was a problem hiding this comment.
My guess it's not checked because a duplicate trait with the same name exists.
| @@ -0,0 +1,21 @@ | |||
| <?php | |||
|
|
|||
| namespace Bug3019; | |||
There was a problem hiding this comment.
Duplicate namespaces/duplicate classes
There was a problem hiding this comment.
Just use a single file used in both RuleTestCase and NodeScopeResolverTest.
There was a problem hiding this comment.
ahh good catch.
when I have some time I will work on the rule to detect duplicate namespaces :)
| { | ||
| public function doFoo(): void | ||
| { | ||
| assertType('string', __CLASS__); |
There was a problem hiding this comment.
My guess it's not checked because a duplicate trait with the same name exists.
|
should this be re-targeted for 1.10.x or will we still have 1.9.x releases before 1.10 is out? |
Yeah, sure, that's the point of these branches :) |
| @@ -0,0 +1,35 @@ | |||
| <?php | |||
|
|
|||
| namespace Bug3019; | |||
There was a problem hiding this comment.
I verified this code still fails without the patch for both Test-cases
|
Nice, thank you! |
closes phpstan/phpstan#3019
the test fails without the fix like
There were 2 failures: 1) PHPStan\Analyser\NodeScopeResolverTest::testFileAsserts with data set "/Users/staabm/workspace/phpstan-src/tests/PHPStan/Analyser/data/bug-3019.php:11" ('type', '/Users/staabm/workspace/phpst...19.php', PHPStan\Type\Constant\ConstantStringType Object (...), PHPStan\Type\Constant\ConstantStringType Object (...), 11) Expected type string, got type 'Bug3019\\Bar' in /Users/staabm/workspace/phpstan-src/tests/PHPStan/Analyser/data/bug-3019.php on line 11. Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'string' +''Bug3019\\Bar'' /Users/staabm/workspace/phpstan-src/src/Testing/TypeInferenceTestCase.php:96 /Users/staabm/workspace/phpstan-src/tests/PHPStan/Analyser/NodeScopeResolverTest.php:1150 2) PHPStan\Analyser\NodeScopeResolverTest::testFileAsserts with data set "/Users/staabm/workspace/phpstan-src/tests/PHPStan/Analyser/data/bug-3019.php:12" ('type', '/Users/staabm/workspace/phpst...19.php', PHPStan\Type\Constant\ConstantStringType Object (...), PHPStan\Type\Constant\ConstantStringType Object (...), 12) Expected type string, got type 'Bug3019' in /Users/staabm/workspace/phpstan-src/tests/PHPStan/Analyser/data/bug-3019.php on line 12. Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'string' +''Bug3019'' 3) PHPStan\Rules\Comparison\UnreachableTernaryElseBranchRuleTest::testBug3019 Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -' +'09: Else branch is unreachable because ternary operator condition is always true. '