Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpcs: use parallel mode #2049

Open
wants to merge 2 commits into
base: 1.9.x
Choose a base branch
from
Open

phpcs: use parallel mode #2049

wants to merge 2 commits into from

Conversation

janedbal
Copy link
Contributor

@janedbal janedbal commented Dec 5, 2022

Ideally, available vcpus should be used...

phpcs.xml Outdated Show resolved Hide resolved
@johnbillion
Copy link
Contributor

What improvement does this give? And does GitHub Actions provide more than one core to run this in parallel during CI?

@staabm
Copy link
Contributor

staabm commented Dec 9, 2022

github actions run with 2 cores on the default instance. whether its a measurable difference need to be proved though.

@staabm
Copy link
Contributor

staabm commented Dec 9, 2022

@theofidry maybe phpcs should have some cpu core autodetection ;)

@janedbal
Copy link
Contributor Author

What improvement does this give?

Minor CI & local speedup.

maybe phpcs should have some cpu core autodetection ;)

Yeah, ideally. Current solution is really naive.


I dont really care about this PR much, but it feels wrong not to utilize faster solution :)

@alies-dev
Copy link

@johnbillion

What improvement does this give? And does GitHub Actions provide more than one core to run this in parallel during CI?

GH provides 2, 4, 8, 16, 64 core runners, also supports custom runners: https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners

I see this PR very beneficial - I can remove some custom core that I wrote to utility all CPUs for different tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants