fix position variance of static method parameters #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There aren't many heavy-generics projects in the integration test suite so that's why we might not see any failures here. But I feel like this should be behind bleedingEdge config because it detects NEW situations in the code. |
jiripudil
force-pushed
the
fix-static-method-position-variance
branch
from
9ac499d
to
96c6421
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up on #2311, I think the
$isStaticcondition was originally meant as an exception for constructors, and was widened to static methods by mistake, because it produces false negatives (https://phpstan.org/r/1bb14b3f-5dc5-4417-9e27-8c0e4c886987).Now that variance in constructors is ignored entirely, we can just remove the conditional and treat parameters in static methods as contravariant.
I’m not sure about the BC impact of this change though. It’s technically a bug fix, but it might disrupt some existing builds. I’m curious to see if any integration tests fail.