Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added failling test for bug 9391 #2435

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 5, 2023

@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

@staabm staabm changed the base branch from 1.11.x to 1.10.x June 5, 2023 11:26
@staabm
Copy link
Contributor Author

staabm commented Jun 5, 2023

let me have a look whether we have the same problem for __serialize and __sleep

@ondrejmirtes
Copy link
Member

I don't think so, union isn't possible in the first place.

@staabm
Copy link
Contributor Author

staabm commented Jun 5, 2023

I don't think so, union isn't possible in the first place.

you are right. I added a test which shows that we don't need a fix

@ondrejmirtes ondrejmirtes merged commit e1058cd into phpstan:1.10.x Jun 6, 2023
377 of 378 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants