New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make result-cache independent from configs include order #2606
Conversation
b3c8576
to
091b8b7
Compare
Thank you! |
@ondrejmirtes any plans for a new release? I think this change will save us minutes on every commit in CI |
You don't have to hypothesize, you can verify it by requiring |
if my testing in CI works as itended I can see PHPStan now using the cache, while it didn't before. this means instead of a full project analysis which takes ~5min, it now only takes ~30secs because of cache utilization per commit. |
Rector using result cache doesn't make any sense. |
I had a typo in my above comment. I updated it to say "PHPStan" not rector" ;) |
Alright, can you please test the dev version anyway? |
I did. thats the numbers for the dev version |
Alright, thank you 😊 |
for reference - full project analysis on my local machine of the same project
vs.
|
closes phpstan/phpstan#8778
tested via phpstan/phpstan#9857