Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninitialized redeclared property on a class that parent initializes #2612

Open
wants to merge 1 commit into
base: 1.10.x
Choose a base branch
from

Conversation

jordisala1991
Copy link

Fix for: phpstan/phpstan#9864

First PR for me here, probably will be doing stuff wrong 馃槄

@jordisala1991 jordisala1991 changed the base branch from 1.11.x to 1.10.x September 8, 2023 14:57
@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

@jordisala1991
Copy link
Author

I took a deep look at the code but I barely understand what is happening. The getUninitializedProperties from ClassPropertiesNode seems to not take into account properties initialized on parents. Should I try to fix that, or the fix should be done somewhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants