Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make int ranges generic #2642

Open
wants to merge 1 commit into
base: 1.11.x
Choose a base branch
from
Open

Make int ranges generic #2642

wants to merge 1 commit into from

Conversation

rvanvelzen
Copy link
Contributor

@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

ondrejmirtes
ondrejmirtes requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder - do we need a new GenericIntegerRangeType for this? Other types have a similar capability out of the box. Can we just change IntegerRangeType to support this?

@rvanvelzen
Copy link
Contributor Author

I did consider that option, but given that IntegerRangeType is public api and requires ?int bounds, it didn't seem viable to me.

@ondrejmirtes
Copy link
Member

@rvanvelzen Can we make a new IntegerRangeType, deprecate the old one, and start using the new one everywhere? In 2.0 I'd just renamed the new one to the current IntegerRangeType name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rvanvelzen @phpstan-bot @ondrejmirtes