Don't collapse Traversable with php-src native traversable objects #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
staabm
commented
Oct 12, 2023
| use Traversable; | ||
| use function PHPStan\Testing\assertType; | ||
|
|
||
| class HelloWorld |
There was a problem hiding this comment.
before this PR: https://phpstan.org/r/6c9c4317-0a4e-4c63-a06b-79865b9aaea3
ondrejmirtes
requested changes
Oct 12, 2023
| @@ -138,6 +140,17 @@ public function isSuperTypeOf(Type $type): TrinaryLogic | |||
| return $type->isSubTypeOf($this); | |||
| } | |||
|
|
|||
| // don't collapse Traversable with classes which also implement Traversable to support phpstan-dba | |||
| // in inferring Traversable shapes onto php-src builtin classes | |||
| if ($this->getClassName() === Traversable::class) { | |||
There was a problem hiding this comment.
You can't special-case this about Traversable, this needs to work generally.
|
I tried a fix and it's hard: phpstan/phpstan#10008 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#10008