Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while observing memory consumption of PHPStan I noticed a difference between what PHPStan reports as "used memory" and what the operating system resource monitor reports.
especially in the last few seconds of the phpstan run, I noticed a climb in the very end, which was not at all reflected.
running
php phpstan analyse -c myphpstan.neon.dist -vvv --debug
on my example projects... before this PR ends in
the end-memory result seems identical with what was reported in the last "consumed"-line. the consumption itself is pretty accurate while running but only a climb up to ~690 at the very end is missing.
After this PR I am taking the memory-peak of the master process into account right before printing the message.
With this change I am now getting something like
which matches pretty good what I am getting from the operating system.
note the difference between the "used memory" metric and the one of the last "consumed" line