[Reflection] Update return types in some reflection methods #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
phansys
force-pushed
the
reflection_named_type
branch
2 times, most recently
from
dcb6ed7
to
297936d
Compare
|
I noticed you also opened a PR at php-src. just a note: the reported problem might get fixed, when php8-stubs include the upstream php-src change. we will see. |
phansys
force-pushed
the
reflection_named_type
branch
from
297936d
to
2b2af4e
Compare
|
I disagree with these changes. These methods simply return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, confirm I should I also update the existing stubs.
IIUC, stubs from PHPStorm already declare the proper return types through attributes depending on the PHP version, but I guess they are not being parsed here.
See https://phpstan.org/r/85179264-493f-4b65-a8ff-4af5b45b31c1.