Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null coalesce assignment type #2702

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix null coalesce assignment type #2702

merged 1 commit into from
Oct 28, 2023

Conversation

hirokinoue
Copy link
Contributor

@hirokinoue
Copy link
Contributor Author

Hi, I'm new to phptan-src. I created a pull request referred to several merged pull requests. Any advice is welcome. Thank you in advance.

@ondrejmirtes
Copy link
Member

Perfect, thank you very much!

@ondrejmirtes ondrejmirtes merged commit 849ea86 into phpstan:1.10.x Oct 28, 2023
415 of 417 checks passed
@ondrejmirtes ondrejmirtes mentioned this pull request Oct 28, 2023
Closed
@ondrejmirtes
Copy link
Member

I encourage you to look into more "easy fixes" issues (https://github.com/phpstan/phpstan/milestone/8) :) They might not be exactly "easy" to figure out, I mark issues as "easy fixes" where I'm sure it's actually fixable in the current feature set of PHPStan and doesn't require any fundamental changes or refactorings :)

The rule of thumb is - if the fix takes less than 50 lines of code, you're good to go, if it takes more and is tricker than that, I probably misqualified the issue and shouldn't be marked as easy to fix :)

@hirokinoue hirokinoue deleted the bug9995 branch October 28, 2023 15:48
@hirokinoue
Copy link
Contributor Author

Thank you so much for your review and advice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hirokinoue @ondrejmirtes