More precise falsey isset() #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Nov 2, 2023
ondrejmirtes
requested changes
Nov 2, 2023
src/Analyser/TypeSpecifier.php
Outdated
|
|
||
| $type = $scope->getType($var); | ||
| if ( | ||
| !$type instanceof MixedType && !TypeCombinator::containsNull($type) |
There was a problem hiding this comment.
!$type instanceof MixedType && doesn't need to be there as TypeCombinator::containsNull will never return true for MixedType
There was a problem hiding this comment.
without this explicit MixedType check the
function mixedIsset(mixed $m): void
{
if (isset($m)) {
assertType("mixed~null", $m);
} else {
assertType("null", $m);
}
}
case will not succeed. I turned the conditions arround, maybe its more readable now.
ondrejmirtes
force-pushed
the
not-isset
branch
from
9823c83
to
001ad45
Compare
|
I knew deep down the condition really wasn't needed. |
|
Thank you. |
This was referenced Nov 2, 2023
Closed
Closed
|
awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split off parts out from #2657 since it gets too complicated.
lets do it one step at a time instead