Update function map for ext-mongodb 1.17 #2768
Conversation
alcaeus
force-pushed
the
mongodb-1.17-stubs
branch
from
71ef32b
to
1c10964
Compare
resources/functionMap.php
Outdated
| 'MongoDB\Driver\Monitoring\addSubscriber' => ['void', 'subscriber'=>'MongoDB\Driver\Monitoring\Subscriber'], | ||
| 'MongoDB\Driver\Monitoring\removeSubscriber' => ['void', 'subscriber'=>'MongoDB\Driver\Monitoring\Subscriber'], | ||
| 'MongoDB\BSON\Binary::__construct' => ['void', 'data'=>'string', 'type='=>'int'], | ||
| 'MongoDB\BSON\fromJSON' => ['string', 'json' => 'string'], |
There was a problem hiding this comment.
Because of the => and => change this is very hard to review. Please do not change this formatting as the rest of the file also use =>.
|
You can view changes without whitespaces: https://github.com/phpstan/phpstan-src/pull/2768/files?diff=unified&w=1 There are a few lines at the bottom that also have that space, and the tooling we use outputs the code with whitespaces as they are required by other tools where we re-use this code (e.g. Psalm). If you insist I can remove them, but it's an extra effort I'd like to avoid as we're already having to update these stubs in three places. I'm also happy to create a separate pull request that adds whitespaces to the rest of the file to make it compliant with widely accepted coding standards. |
|
Despite me also being fond of coding style, making such a big change on a stable branch just for the sake of coding style is unwise. It would cause all kinds of conflicts on other open PRs, WIPs, and altered forks |
|
I just unified the array format in functionMap: 97d9ddf Please fix the formatting of your PR. |
alcaeus
force-pushed
the
mongodb-1.17-stubs
branch
from
1c10964
to
4291f59
Compare
|
Thank you. |
For the record, there are spaces on first array level, e.g.: 'MongoDB\Driver\WriteConcern::unserialize' => ['void', 'data'=>'string'],Not sure why the parameter list is special in that regard, especially considering that the rest of the source code uses different formatting, but it's not my call 🤷♂️ |
No description provided.