Non-numeric strings in pow() lead to error #2796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Nov 29, 2023
| @@ -177,3 +177,23 @@ function doFoo(int $intA, int $intB, string $s, bool $bool, $numericS, float $fl | |||
| assertType('*ERROR*', $bool ** $arr); | |||
| assertType('*ERROR*', $bool ** []); | |||
| }; | |||
|
|
|||
| function invalidConstantOperands(): void { | |||
| assertType('*ERROR*', 'a' ** 1); | |||
There was a problem hiding this comment.
php fatal errors on regular (non-numeric strings). I think we should too
|
This pull request has been marked as ready for review. |
staabm
commented
Nov 29, 2023
| $allowedOperandTypes = new UnionType([ | ||
| new IntegerType(), | ||
| new FloatType(), | ||
| new IntersectionType([ |
There was a problem hiding this comment.
limited the allowed types to numeric-strings (instead of just string before)
staabm
commented
Nov 29, 2023
| /** | ||
| * @return float|int | ||
| */ | ||
| private static function pow(mixed $base, mixed $exp) |
There was a problem hiding this comment.
I had to wrap the pow operation into a separate method, as otherwise phpstan errored about invalid args to pow() / **?
ondrejmirtes
requested changes
Jan 6, 2024
| new NullType(), | ||
| ]); | ||
| if (!$allowedOperandTypes->isSuperTypeOf($exponent)->yes()) { | ||
| return new ErrorType(); |
There was a problem hiding this comment.
I disagree with returning ErrorType here.
string might still be a numeric-string so it's wrong to return ErrorType for that case.
We just want to prevent the internal error the issue is about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#10125