Simplify arrow-function return type inference #2873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrow-functions can't have a void return type
staabm
force-pushed
the
less-void-keeping
branch
from
74d8202
to
48420bf
Compare
staabm
commented
Jan 14, 2024
| @@ -1242,7 +1242,7 @@ private function resolveType(string $exprString, Expr $node): Type | |||
| new VoidType(), | |||
| ]); | |||
| } else { | |||
| $returnType = $arrowScope->getKeepVoidType($node->expr); | |||
| $returnType = $arrowScope->getType($node->expr); | |||
| if ($node->returnType !== null) { | |||
| $returnType = TypehintHelper::decideType($this->getFunctionType($node->returnType, false, false), $returnType); | |||
There was a problem hiding this comment.
I came to the conclusion that getKeepVoidType might not be necessary because the following IF did not keep void when infered from $node->returnType either
|
This pull request has been marked as ready for review. |
|
//cc @herndlm |
|
If no tests were failing before, and this doesn't fix anything, what is the purpose of this change? |
|
Its a line of code which did not make sense to me while looking thru functionType stuff. I have no concrete case in mind - feel free to close |
|
If it ain't broke don't fix it :) But when testing a piece of code I found a false negative on 1.10.x: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow-functions can't have a void return type
refs #2778 (comment)