Reproduce Bug 10523 #2897
Merged
Reproduce Bug 10523 #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
staabm
commented
Feb 2, 2024
| @@ -355,6 +359,12 @@ private function getMethodsCalledFromConstructor( | |||
| continue; | |||
| } | |||
|
|
|||
| if ($inMethod->getName() !== '__construct') { | |||
There was a problem hiding this comment.
at this point we take the properties which have been assigned in __construct over to the additionalConstructor methods as described in phpstan/phpstan#10523 (comment).
staabm
force-pushed
the
bug10523
branch
3 times, most recently
from
90db4f7
to
664d819
Compare
|
I think this one is ready for a review |
|
This also fixes phpstan/phpstan#10822 please add a regression test for that. |
|
@ondrejmirtes here you are |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#10523
closes phpstan/phpstan#10822