Keep numeric-strings in str_repeat() #2914
Conversation
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
repeat-numeric-s
branch
from
ef7d199
to
f4b72a7
Compare
| @@ -74,6 +75,10 @@ public function getTypeFromFunctionCall( | |||
| $accessoryTypes[] = new AccessoryLiteralStringType(); | |||
| } | |||
|
|
|||
| if ($inputType->isNumericString()->yes()) { | |||
| $accessoryTypes[] = new AccessoryNumericStringType(); | |||
There was a problem hiding this comment.
I'm afraid this can be a bit tricky. Repeating a numeric type multiple times can lead to a non-numeric type: https://3v4l.org/aRBdZ
There was a problem hiding this comment.
So we should probably do it only with a constant (literal) types with no decimal points.
There was a problem hiding this comment.
good catch. fixed, thanks.
There was a problem hiding this comment.
I think it should only be done for strings that only contain digits. Because of these numeric strings: https://3v4l.org/U4bM2
It should also be ensured that the multiplier is not 0.
There was a problem hiding this comment.
ohh my, its even different across php versions ;)
staabm
force-pushed
the
repeat-numeric-s
branch
2 times, most recently
from
6275102
to
480b972
Compare
staabm
force-pushed
the
repeat-numeric-s
branch
3 times, most recently
from
3851f2f
to
0099b70
Compare
|
I had a look into blackfire profiles and did not see any bottlenecks/resource hogs |
clxmstaab
force-pushed
the
repeat-numeric-s
branch
from
c94ad6c
to
1e874c5
Compare
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
repeat-numeric-s
branch
from
5449067
to
b579b25
Compare
staabm
force-pushed
the
repeat-numeric-s
branch
from
b579b25
to
5b4a4a2
Compare
|
Thank you. |
closes phpstan/phpstan#10572