Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make phpunit fail if a --filter does not execute any tests #2924

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Make phpunit fail if a --filter does not execute any tests #2924

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc050c8
Make phpunit fail if a --filter does not execute any tests
staabm Feb 18, 2024
a61d873
run tests in isolation, as they depend on global state (ENV vars)
staabm Feb 18, 2024
3f02ee9
Update TableErrorFormatterTest.php
staabm Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
bootstrap="tests/bootstrap.php"
cacheResult="false"
colors="true"
executionOrder="random"
failOnRisky="true"
failOnWarning="true"
failOnEmptyTestSuite="true"
beStrictAboutChangesToGlobalState="true"
beStrictAboutCoversAnnotation="true"
beStrictAboutOutputDuringTests="true"
Expand Down
3 changes: 3 additions & 0 deletions tests/PHPStan/Command/ErrorFormatter/TableErrorFormatterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
use function sprintf;
use const PHP_VERSION_ID;

/**
* @runTestsInSeparateProcesses
*/
class TableErrorFormatterTest extends ErrorFormatterTestCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just think that this test was influenced by some other test that set an env variable.

This diff is a workaround, not a solution to the problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I am still in the process of finding a proper solution. the tests don't fail locally, so I push and look at CI results

{

Expand Down
Loading