-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure http_response_header is a list<string> #2959
Conversation
since no test is failling after the change it seems we are missing a NodeScopeResolverTest with a type inference assertion for this variable :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thank you
use function PHPStan\Testing\assertType; | ||
|
||
file_get_contents('https://example.org'); | ||
assertType('list<string>', $http_response_header); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh I think you are missing another assert for assertNativeType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok hopefully I did this correctly :)
Thank you! |
Not sure if that's the proper/best use of AccessoryArrayListType, but anyway I hope the intent is clear :)