Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 10057: DomDocument load return type #2975

Merged
merged 1 commit into from Mar 19, 2024

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Mar 17, 2024

I dunno if it closes phpstan/phpstan#10057

because of the php-8 issue, cf phpstan/phpstan#10057 (comment)

@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

@staabm
Copy link
Contributor

staabm commented Mar 18, 2024

I dunno if it closes phpstan/phpstan#10057

if you are not sure, you could add a NodeScopeResolverTest to verify your assumption

@VincentLanglet
Copy link
Contributor Author

if you are not sure, you could add a NodeScopeResolverTest to verify your assumption

I'm pretty sure it won't close the PHP 8 part (and only fix the issue on php 7).

But I dunno how to fix it for PHP 8 since it's in phpstan/php-8-stubs and https://github.com/phpstan/php-8-stubs/blob/main/extractor/extract.php is not easy to understand at first read.

@ondrejmirtes
Copy link
Member

Because the type in phpstan/php-8-stubs is only in a PHPDoc then changing functionMap.php here actually works, as can be seen in the Reflection golden test: https://github.com/phpstan/phpstan-src/actions/runs/8317200612/job/22757684538

@ondrejmirtes ondrejmirtes merged commit 200641e into phpstan:1.10.x Mar 19, 2024
443 of 444 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants