Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages on unnamed parameters #3010

Merged
merged 1 commit into from Apr 12, 2024
Merged

Improve error messages on unnamed parameters #3010

merged 1 commit into from Apr 12, 2024

Conversation

takaram
Copy link
Contributor

@takaram takaram commented Apr 9, 2024

@staabm
Copy link
Contributor

staabm commented Apr 10, 2024 •
edited

remaining errors are related. you need to adjust the test expectations.

see

@takaram takaram force-pushed the improve-parameter-error-message branch from 7b01598 to 8619690 Compare April 10, 2024 12:12
@takaram
Copy link
Contributor Author

takaram commented Apr 10, 2024

@staabm
Thanks, I fixed the levels test issue.

@ondrejmirtes
Copy link
Member

Really nice, thank you! :)

@ondrejmirtes ondrejmirtes mentioned this pull request Apr 12, 2024
Closed
@ondrejmirtes ondrejmirtes merged commit f71da02 into phpstan:1.10.x Apr 12, 2024
442 of 443 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@takaram @staabm @ondrejmirtes