Support multi-byte string function variants #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
|
Some tests with multibyte characters would be good as well 👍 |
rvanvelzen
reviewed
May 3, 2024
| @@ -25,7 +26,7 @@ class SubstrDynamicReturnTypeExtension implements DynamicFunctionReturnTypeExten | |||
|
|
|||
| public function isFunctionSupported(FunctionReflection $functionReflection): bool | |||
| { | |||
| return $functionReflection->getName() === 'substr'; | |||
| return in_array($functionReflection->getName(), ['substr', 'mb_substr'], true); | |||
There was a problem hiding this comment.
The substr() calls below should be changed to use the correct function as well.
clxmstaab
force-pushed
the
nar
branch
3 times, most recently
from
bcebb98
to
8d078f5
Compare
staabm
force-pushed
the
nar
branch
2 times, most recently
from
8cf4e2b
to
a7a57ba
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.