array_slice() returns non-empty array for existing offsets and positive limit #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jun 3, 2024
Comment on lines
+56
to
+61
| if ($offsetType !== null | ||
| && $valueType->hasOffsetValueType($offsetType)->yes() | ||
| && ($limitType === null || IntegerRangeType::fromInterval(1, null)->isSuperTypeOf($limitType)->yes()) | ||
| ) { | ||
| return $valueType; | ||
| } |
There was a problem hiding this comment.
the actual fix.
all changes above are just refactoring.
|
This pull request has been marked as ready for review. |
staabm
commented
Jun 4, 2024
staabm
commented
Jun 4, 2024
staabm
commented
Jun 4, 2024
| ]; | ||
| assertType("array{'zib', 'zib 2'}", $list); | ||
| shuffle($list); | ||
| assertType("non-empty-array<0|1, 'zib'|'zib 2'>&list", $list); |
There was a problem hiding this comment.
I think this PR can't work as is, because the type after shuffle is already not precise enough.
at this point we don't know anymore, that all keys will always exist.
There was a problem hiding this comment.
implemented a more generic approach with #3124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#10721