Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure exec group CI is executed in default order #3142

Closed
wants to merge 1 commit into from

Conversation

thg2k
Copy link
Contributor

@thg2k thg2k commented Jun 10, 2024

Due to the recent addition of the random execution order in phpunit.xml, the test TraitsCachingIssueIntegrationTest::testCachingIssue was failing due to the expectation to be executed exactly in the data order.

Due to the recent addition of the random execution order in phpunit.xml,
the test TraitsCachingIssueIntegrationTest::testCachingIssue was failing
due to the expectation to be executed exactly in the data order.
@thg2k
Copy link
Contributor Author

thg2k commented Jun 10, 2024

This was broken in #2924 (commit a018f1e).

I don't know how else to fix the problem, I digged around phpunit but there seems no annotation for dataProviders to mark the order as default on a single case basis. The current solution seems to fix the problem tho.

@ondrejmirtes
Copy link
Member

I think we should remove TraitsCachingIssueIntegrationTest and recreate it in e2e-tests.yml. It gave me more headaches recently.

@thg2k
Copy link
Contributor Author

thg2k commented Jun 10, 2024

I think we should remove TraitsCachingIssueIntegrationTest and recreate it in e2e-tests.yml. It gave me more headaches recently.

That I don't know about, but if you agree this patch fixes the current problem I'd suggest to apply it, otherwise this test is bound to fail based on the randomization order. At least you get a green mark 😄

@ondrejmirtes
Copy link
Member

I'm sorry, I disagree with this patch. I'd like to pursue the direction I outlined above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants