Remove incorrect overrides in PHP8 for proc_get_status #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The official doc is flag as A lot of |
|
Huh, I wasn't under the impression that was a type error which would cause the |
|
Hi, the line could just be removed with the same effect. PHPStan uses official php-src stubs on PHP 8 so it will be inferred from that (and merged with functionMap.php): https://github.com/phpstan/php-8-stubs/blob/main/stubs/ext/standard/proc_get_status.php |
|
Should I roll back to the previous version then? That is what I originally did. |
|
Yes, the first commit was sufficient 👍 |
…ignature" This reverts commit 7d79462.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #288: the more-precise return shape is overridden with a less-specific version when running under PHP8. This removes the override which seems to have come from an external import.
I'm not sure what's up with the original removal of
|false, which doesn't seem to match up with the official docs