Type cast fixes, add tests for intval(), boolval(), floatval() #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
force-pushed
the
type-cast-fixes
branch
from
e4ac3fa
to
8bfdf17
Compare
|
Awesome, thank you! I added a commit: 8bfdf17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds return type extensions and tests for
intval(),boolval(),floatval()(anddoubleval()).Additionally it includes two small fixes:
(int)'foo'/intval('foo')now correctly evaluate to0(similar forfloat)(int)[]/intval([])now correctly evaluate to0(or1if the array is non-empty, similar forfloat)While maybe not very useful, they do not cause any notice, warning or errors in any PHP versions, thus they should be supported by PHPStan.
I left out weird constructs like
strval([])orintval(new stdClass())which technically evaluating to'Array'and1respectively. Not sure if it's useful to support that, since these always cause notices anyway (even warnings since PHP 8).