Added ArrayFlipFunctionReturnTypeExtension, Cover non-empty-array in array_flip
#583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jul 19, 2021
|
Todo: add more test coverage |
staabm
commented
Jul 20, 2021
Comment on lines
48
to
50
| if ($argType->isIterableAtLeastOnce()->yes()) { | ||
| $flippedArrayType = TypeCombinator::intersect($flippedArrayType, new NonEmptyArrayType()); | ||
| } |
There was a problem hiding this comment.
this is the actual feature I primarily want to implement with this PR.
regarding the key/type flipping I did a lot of guesswork.. I need some guidance on how this should look like :-/
staabm
commented
Jul 20, 2021
ondrejmirtes
requested changes
Jul 20, 2021
staabm
commented
Jul 20, 2021
|
turns out I had a typo in my tests. should be good to go. |
staabm
changed the title
array_fliparray_flip
staabm
changed the title
array_flipArrayFlipFunctionReturnTypeExtension, Cover non-empty-array in array_flip
ondrejmirtes
approved these changes
Jul 20, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs phpstan/phpstan#5327
https://3v4l.org/KUGTa