Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-empty-array with positive-int given to array_fill #602

Closed
wants to merge 7 commits into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jul 31, 2021

@staabm staabm changed the title Support non-empty-array with positive-int given to array_fill Support non-empty-array with positive-int given to array_fill Jul 31, 2021
@staabm staabm changed the title Support non-empty-array with positive-int given to array_fill Support non-empty-array with positive-int given to array_fill Jul 31, 2021
@staabm
Copy link
Contributor Author

staabm commented Jul 31, 2021

this failling test makes me crazy

grafik

when adjusting the expected type and remove the nonEmpty case it fails because of a missing nonEmpty.
when adding it, it yells about it would be too much.

also, I can't find the actual sources of this array_fill(2, $integer, ...) test-case in the data-providing file array-functions.php?

@ondrejmirtes
Copy link
Member

when adding it, it yells about it would be too much.

Maybe it's different PHP versions that make the assert fail? I don't see otherwise a reason for this behaviour, one type always has to be correct.

 I can't find the actual sources

Check out LegacyNodeScoperResolverTest.php, it works differently.

@staabm
Copy link
Contributor Author

staabm commented Aug 17, 2021

covered in #603

@staabm staabm closed this Aug 17, 2021
@staabm staabm deleted the array-fill branch August 17, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants