Added rand() return-type extension #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Aug 1, 2021
| @@ -16,11 +17,15 @@ class RandomIntFunctionReturnTypeExtension implements \PHPStan\Type\DynamicFunct | |||
|
|
|||
| public function isFunctionSupported(FunctionReflection $functionReflection): bool | |||
| { | |||
| return $functionReflection->getName() === 'random_int'; | |||
| return in_array($functionReflection->getName(), ['random_int', 'rand']); | |||
There was a problem hiding this comment.
I figured functionality wise, it would be easiest to use the same ReturnTypeExtension for rand and random_int.
I did not change the class-name to not break BC
staabm
commented
Aug 1, 2021
ondrejmirtes
requested changes
Aug 1, 2021
|
I think this is good to go. turning the zero-args case into a positive-int was great advice, which improved types in a few spots quite a bit! |
ondrejmirtes
requested changes
Aug 1, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#5402