Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrong return type of imagejpeg GD function #619

Merged
merged 1 commit into from Aug 12, 2021
Merged

Remove wrong return type of imagejpeg GD function #619

merged 1 commit into from Aug 12, 2021

Conversation

MauricioFauth
Copy link
Contributor

The return type of the imagejpeg function is bool not false|string.

 imagejpeg(GdImage $image, resource|string|null $file = null, int $quality = -1): bool

Introduced by #265 and not removed by #277.

@MauricioFauth
Remove wrong return type of imagejpeg GD function
dfb49ec 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@ondrejmirtes ondrejmirtes merged commit 07c542f into phpstan:master Aug 12, 2021
@ondrejmirtes
Copy link
Member

Thank you.

@MauricioFauth MauricioFauth deleted the imagejpeg-return-type branch August 12, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MauricioFauth @ondrejmirtes