Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ext-ds stubs #675

Merged
merged 1 commit into from Sep 16, 2021
Merged

Improve ext-ds stubs #675

merged 1 commit into from Sep 16, 2021

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Sep 16, 2021 •
edited

Trying to fix phpstan/phpstan#5635

ondrejmirtes
ondrejmirtes requested changes Sep 16, 2021
View reviewed changes
stubs/ext-ds.stub Outdated Show resolved Hide resolved
@enumag
Copy link
Contributor Author

enumag commented Sep 16, 2021

@ondrejmirtes Something is failing but it seems unrelated to my changes.

php bin/phpstan analyse -c conf/config.stubFiles.neon -l 8 tests/notAutoloaded/empty.php
Stub file D:\a\phpstan-src\phpstan-src\stubs\ReflectionAttribute.stub is added multiple times.

@ondrejmirtes
Copy link
Member

Please rebase, this is fixed on master.

@ondrejmirtes
Copy link
Member

I see it's passing on Ubuntu so this is fine! 👍

@ondrejmirtes ondrejmirtes marked this pull request as ready for review September 16, 2021 16:38
@ondrejmirtes ondrejmirtes merged commit 01321a6 into phpstan:master Sep 16, 2021
@enumag enumag deleted the fix-ds branch September 16, 2021 16:39
@simPod simPod mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@enumag @ondrejmirtes