Resolve remaining predefined constants#693
Merged
ondrejmirtes merged 2 commits intophpstan:masterfrom Jan 30, 2022
herndlm:feature/resolve-remaining-predefined-constants
Merged
Resolve remaining predefined constants#693ondrejmirtes merged 2 commits intophpstan:masterfrom herndlm:feature/resolve-remaining-predefined-constants
ondrejmirtes merged 2 commits intophpstan:masterfrom
herndlm:feature/resolve-remaining-predefined-constants
Conversation
staabm
reviewed
Sep 29, 2021
staabm
reviewed
Sep 29, 2021
staabm
reviewed
Sep 29, 2021
staabm
reviewed
Sep 29, 2021
staabm
reviewed
Sep 29, 2021
Contributor
Author
|
What do you think @ondrejmirtes and what about the remaining open conversations @staabm? |
mvorisek
reviewed
Oct 13, 2021
mvorisek
reviewed
Oct 13, 2021
Contributor
Author
|
rebased and cleaned up a bit |
Member
|
Hi, I really don’t want to read 64 comments. Anything worth my attention before I review? 😊 |
Contributor
Author
|
Sorry for spaming you with the rebases (wanted to make the CI green again) :/ Most of it was about the PHP version constants (should we have upper limits or not). So a look/check/special think there might be worth when reviewing. The rest is resolved. |
staabm
reviewed
Jan 27, 2022
Merged
This resolves the remaining predefined constants that are configured via `dynamicConstantNames` and differ from what reflection is able to resolve.
staabm
reviewed
Jan 29, 2022
Member
|
Thank you! |
Contributor
Author
|
thx, I hope this doesn't introduce annoying new errors 🤞 |
Member
|
I’ll /cc you if it does 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #684
This resolves the remaining predefined constants that are configured via
dynamicConstantNamesand differ from what reflection is able to resolve.There are a few constants that are defined via compilation flags where I was not a 100% sure if they can be empty or not.
And, of course, there would be many more constants from extensions that could be defined potentially and the resolving code could be refactored or grouped differently, but for now I wanted to keep it simple and adapt it based on the feedback I get.
Currently it's grouped/sorted like the following with links to docs