Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ArrayAccess in ext-ds #723

Merged
merged 1 commit into from Oct 22, 2021
Merged

Implement ArrayAccess in ext-ds #723

merged 1 commit into from Oct 22, 2021

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Oct 20, 2021

These classes implement ArrayAccess

See https://www.php.net/manual/en/class.ds-sequence.php

cc @enumag

@enumag
Copy link
Contributor

enumag commented Oct 20, 2021

I'm not personally using ArrayAccess with these classes but sure it seems fine. :-)

@ondrejmirtes ondrejmirtes merged commit 50fba6b into phpstan:master Oct 22, 2021
@ondrejmirtes
Copy link
Member

Thank you!

@simPod simPod deleted the implement-array-access branch October 22, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enumag enumag enumag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@simPod @enumag @ondrejmirtes